fix: client not receiving broadcast tx#995
Merged
Conversation
Klakurka
requested review from
Klakurka,
ScottMcDermid and
lissavxo
and removed request for
ScottMcDermid and
lissavxo
Klakurka
approved these changes
Apr 8, 2025
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
One comment nit; non-blocking.
| const userIp = headersForwardedAddresses === undefined ? '' : headersForwardedAddresses.split(',')[0] | ||
| if (userIp === '') { | ||
| throw new Error('Local IP not defined.') | ||
| console.error('Local IP not defined.') |
Member
There was a problem hiding this comment.
IMO this is a "so what" error message. What needs to happen for this to resolve itself? What would cause it in the first place?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #
Description
Fixes issue where the websocket broadcast TX wouldn't appear for the client.
Test plan
Check if either a paybutton client hooked up to localhost OR localhost:3000/button/ are both receiving living updates when a tx arrive.